Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nokia][chassis] Update Nokia-IXR7250E chassis device data #21703

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

mlok-nokia
Copy link
Contributor

@mlok-nokia mlok-nokia commented Feb 11, 2025

Why I did it

No need to remove /sys/firmware/efi/efivars/dump* in the platform_reboot since pstore has handled them in 202405 branch and after

Work item tracking
  • Microsoft ADO [31408729]:

How I did it

Commented out the line "rm /sys/firmware/efi/efivars/dump* " in platform_reboot script. These dump files have been handled by pstore.

How to verify it

  1. Trigger system crash to reboot
  2. after the system boot up, check if there is any /sys/firmware/efi/efivars/dump* files -- there should not be any.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202405
  • 202411

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

  -- No need to remove /sys/firmware/efi/efivars/dump* in the platf_reboot since pstore has handled it in 202405 branch

Signed-off-by: mlok <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mlok-nokia
Copy link
Contributor Author

@judyjoseph, @arlakshm and @rlhui This PR modifies the Nokia platform_reboot by commented out "rm efi/du,p" files since they have been handled by pstore which is enabled 202405. Please review it

@rlhui
Copy link
Contributor

rlhui commented Feb 14, 2025

@arlakshm , can we please include msft ado?

@rlhui
Copy link
Contributor

rlhui commented Feb 14, 2025

@judyjoseph, @arlakshm and @rlhui This PR modifies the Nokia platform_reboot by commented out "rm efi/du,p" files since they have been handled by pstore which is enabled 202405. Please review it

wanted to double-confirm if this PR needs also back-port to 202405 and 202411, as I see "backport to 202405" was checked as needed in the PR description

@mlok-nokia
Copy link
Contributor Author

@judyjoseph, @arlakshm and @rlhui This PR modifies the Nokia platform_reboot by commented out "rm efi/du,p" files since they have been handled by pstore which is enabled 202405. Please review it

wanted to double-confirm if this PR needs also back-port to 202405 and 202411, as I see "backport to 202405" was checked as needed in the PR description

Please back port 202411 also.

@arlakshm
Copy link
Contributor

@arlakshm , can we please include msft ado?

@rlhui ADO for to track this change https://msazure.visualstudio.com/One/_workitems/edit/31408729

@rlhui
Copy link
Contributor

rlhui commented Feb 14, 2025

@arlakshm , can we please include msft ado?

@rlhui ADO for to track this change https://msazure.visualstudio.com/One/_workitems/edit/31408729

thanks, please add to above Work item tracking under PR description?

@arlakshm
Copy link
Contributor

@arlakshm , can we please include msft ado?

@rlhui ADO for to track this change https://msazure.visualstudio.com/One/_workitems/edit/31408729

thanks, please add to above Work item tracking under PR description?

updated the description

@rlhui rlhui merged commit 5e8e658 into sonic-net:master Feb 14, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants